RabbitMQ version 3.4.1 #160
Conversation
Disabling the restarting of the rabbitmq service upon enabling or disabling a plugin, since it is not longer needed in RabbitMQ >= 3.4.x
| @@ -24,13 +24,11 @@ | |||
| node['rabbitmq']['enabled_plugins'].each do |plugin| | |||
| rabbitmq_plugin plugin do | |||
| action :enable | |||
| notifies :restart, "service[#{node['rabbitmq']['service_name']}]" | |||
There was a problem hiding this comment.
This is beyond what the pull request title says. Would be nice if you could justify such changes in a PR comment.
There was a problem hiding this comment.
Sorry about that, and the delay to answer.
RabbitMQ 3.4 does not require a restart in the rabbitmq service to enable or disable a plugin (enhancement 24926 in rabbitmq, "allow plugins to be enabled / disabled without restarting the server"). I included that as it is part of the advantages of the upgraded version.
|
Is it possible to write some Chefspec test(s) around this? It seems we are lacking them in this repo. |
|
I'll try and write some! |
|
It seems our Rakefile is broken with this too: #162 If you could confirm this and +1 it I can merge this too. |
|
@dggc i got a start of some chefspec framework here on this branch: https://github.com/jjasghar/rabbitmq/tree/chefspec_update |
|
It looks like RabbitMQ released 3.4.2, i have #166 already ready to go and it's passing the preliminary tests. Can you take a stab at it and branch off that for anything that is also required for the 3.4.1 release? |
|
I'm going to close this because i pulled the change over to #166 |
This pull request updates the default version of RabbitMQ to 3.4.1, and removes the restart notification upon enabling a plugin, since it is no longer needed in RabbitMQ >= 3.4.x