-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ssl_ciphers #255
Added ssl_ciphers #255
Conversation
@jjasghar This is another one we would like to get in this week, it's also just basic config options. |
@cmluciano @jjasghar Humm, seems travis failure is NOT related to this change, but rather to this one: #236 Looks like we pulled out the case to include the yum-epel and yum-erlang, but did not cleanup the specs or the metadata. |
Yes that was on purpose. The tests passes with my changes. The reason that they are failing now is due to the removal from the erlang package recipe change. |
@cmluciano thx for the update. I have removed those tests from the spec with my latest push. |
@@ -56,6 +56,12 @@ | |||
:mode => 00644) | |||
end | |||
|
|||
it 'allows ssl ciphers' do | |||
node.set['rabbitmq']['ssl_ciphers'] = ['ecdhe_ecdsa,aes_128_cbc,sha256', 'ecdhe_ecdsa,aes_256_cbc,sha'] | |||
expect(chef_run).not_to render_file('/etc/rabbitmq/rabbitmq.config').with_content( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just me or not_to
should have been to
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, will clean that up and add in the default case of no specific ciphers.
Allow ssl ciphers to be configured Also minor cleanup for spec with yum
Allow ssl ciphers to be configured