Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single quote and nil issues with cluster recipe #274

Merged
merged 5 commits into from
Jun 16, 2015

Conversation

TheSeubert
Copy link
Contributor

This builds on #267 to add:

  • More fixes to catch single quotes from cluster_status, current_cluster_node_type and node_name

In rare instances, if the cluster_status returns on a non running server or is not clustered yet, the matchers caused no matched and nil errors. Fixes were introduced to pass nil in some functions through and to better handle them specifically with cluster_join:

  • Passthrough of nil in some functions
  • Additional debug logging and handling of nil responses from functions

@TheSeubert
Copy link
Contributor Author

To note, this is also duplicates in some ways of #263 and #273 but with additional changes and differences in the way nil was handled.

@TheSeubert TheSeubert changed the title Remove quote node name Fix single quote and nil issues with cluster recipe May 29, 2015
@xiangyao1989
Copy link

This looks great! Fixed multiple nil issues in this recipe!

jjasghar pushed a commit that referenced this pull request Jun 16, 2015
Fix single quote and nil issues with cluster recipe
@jjasghar jjasghar merged commit a5f320c into rabbitmq:master Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants