Delay start of RabbitMQ on template changes #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This is very important in some other scenarios, e.g. when you want to install a plugin such as rabbitmq_clusterer or autocluster, which alter server boot and assume certain piece of configuration are in place by the time the node starts. |
jjasghar
pushed a commit
that referenced
this pull request
Aug 14, 2015
Delay start of RabbitMQ on template changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #245, I do not think the issue of default user/pass changes being disregarded is solved. The fact that notification on the rabbitmq-env.conf template is immediate causes the service to start before the values can be written to the rabbitmq.conf file by the next resource. This changes fixed the problem for me.
I thought perhaps delaying the notifications would cause all sorts of other recipes and LWRP to fail during the initial chef run because the service is not running, but then I noticed that the service is started down at the bottom of the recipe, so perhaps it is not an issue? It's working for me and my simple wrapper cookbook.