Fix idempotency #554
Closed
Fix idempotency #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will target RabbitMQ 3.7.x or later only, use new config format, and introduce moderate breaking changes.
(cherry picked from commit 4d7ebb0)
(cherry picked from commit 8550a27)
To support versions older than 3.6.0 which are, ahem, out of any kind of support. Ranch, a TCP acceptor library adopted in 3.6.0, forces binary and a few other TCP listener options. Closes rabbitmq#488. (cherry picked from commit 1aa9dc4)
(cherry picked from commit 6b56d54)
(cherry picked from commit 18d2415)
(cherry picked from commit 69d0932)
References rabbitmq#489. (cherry picked from commit 7b771e3)
Still sticking to 3.6.x until new config format support lands.
… of e5a4be3 See rabbitmq#498 to learn more.
It has to be an array so cannot be a name attribute. Falling back to first node's name is a reasonable thing to do which RabbitMQ itself uses.
We still support Chef 12.x at this time.
Conflicts: metadata.rb
Conflicts: metadata.rb
Signed-off-by: Tim Smith <tsmith@chef.io>
To 3.7 for now
Make sure we're calling ::File not Chef::File Signed-off-by: Tim Smith <tsmith@chef.io>
Scope the File exist conditional properly
Invalid platforms were being passed here. I wrote a cookstyle to catch this in the future. Signed-off-by: Tim Smith <tsmith@chef.io>
Fix invalid value_for_platform helper usage
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Fix license acceptance in Travis
This reverts commit 67bfde2.
Chef gives you a name attribute/property by default. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Ubuntu isn't a platform family and we have a nice helper for this Signed-off-by: Tim Smith <tsmith@chef.io>
true/class works but it's not correct Signed-off-by: Tim Smith <tsmith@chef.io>
Additional Cookstyle fixes
Bumps [rack](https://github.com/rack/rack) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@2.0.7...2.0.8) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit a1e881d)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.5 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.5...v1.10.8) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit d37c34b)
(cherry picked from commit 4d0a49f)
(cherry picked from commit 4f80ae9)
…vesupport-6.0.3.1 Bump activesupport from 6.0.0 to 6.0.3.1 (cherry picked from commit 3b3dd04)
Signed-off-by: Wing924 <weihe924stephen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR is to keep idempotency of this cookbook.
The
ohai 'reload_packages'do nothing when no package is installed but still report that some resources are changed.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocument