[COOK-3633] Adding not_if for stopping action during updating erlang cookie

[nonflet]

https://tickets.opscode.com/browse/COOK-3633

It is needed ,because of every time service stopping during chef-client process, even if cluster already configured...
So if we already have "good" erlang cookie, we doesn't need to stop service.

Please merge it as soon , as possible!

[jesseadams]

Hey @nonflet! Thank you for supporting the Opscode Cookbooks! Opscode's process has a couple prerequisites before they will merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on their ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

• http://wiki.opscode.com/display/chef/How+to+Contribute
• http://wiki.opscode.com/display/chef/Code+Review

If you have already done all of that, please consider linking to the ticket in this pull request.

[nonflet]

woooow, people, i'm just adding one check to recipe :))))

[nonflet]

https://tickets.opscode.com/browse/COOK-3633

Ready :)

[jesseadams]

Thanks @nonflet. Once you get a confirmation email from Opscode legal please re-login to JIRA and mark that ticket as "Fix Provided." Thanks!

[nonflet]

mmm, ok, ready, i think

[jesseadams]

@nonflet That ticket has a status of "In Progress" and needs to be "Fix Provided." If you re-login to JIRA after you receive your confirmation email the "Fix Provided" button should appear.

[nonflet]

"Fix Provided" button doesn't appear....

[jesseadams]

@nonflet

1. Did you receive a confirmation email from Opscode legal?
2. Did you use the same email address signing the CLA as you did when you created your account at tickets.opscode.com?

[nonflet]

Yes, confirmation email was received
Yes, the same.

[btm]

@nonflet Our legal department hasn't seen a CLA from you. You need to complete this document: https://secure.echosign.com/public/hostedForm?formid=PJIF5694K6L

[nonflet]

Ready.

[jesseadams]

@nonflet - Now once you receive an email confirmation, please re-login to JIRA and mark the ticket as "Fix Provided." Thanks!

[nonflet]

Ooookey find me pls needed button ....(sure, i re-login)

[jesseadams]

@nonflet - If you haven't got a confirmation email from Opscode legal then they haven't processed your CLA yet.

[nonflet]

Ready, ticket was marked as "Fix Provided"

[nonflet]

Any update , people ?:)

[jesseadams]

Hello @nonflet. Cookbook code reviews only happen on Monday, Wednesday, and Friday and only last for an hour (see https://wiki.opscode.com/display/chef/Code+Review). Additionally, since your ticket was just updated its most likely towards the end of the backlog (see https://tickets.opscode.com/secure/IssueNavigator.jspa?mode=hide&requestId=10970 to see the order in which they are reviewed). It may take a bit (1-2 weeks) for them to get to your contribution but please be patient. Thanks!

[sethvargo]

I'm 👎 on using a conditional for this. Why don't we just set the log action to nothing and then have the template notify the log resource?

[nonflet]

Okey , add "normal" solution, as u wish.
I just added very important check to recipe. Close pull request or merge it.
That's all!
We are waiting a lot of time ....

[btm]

We definitely need to fix this log resource. We should notify the service from something else, like a template resource. The not_if here seems a bit fragile because it seems not very specific about what it's looking for. @sethvargo, could you break the notify out of the log resource?

[sethvargo]

#86

[nonflet]

Ok, thx :)