Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose the heartbeat configuration parameter #87

Merged
merged 1 commit into from
Nov 27, 2014

Conversation

kisoku
Copy link

@kisoku kisoku commented Oct 22, 2013

Opscode ticket: COOK-3867

@michaelklishin
Copy link
Member

👍

@flah00
Copy link
Contributor

flah00 commented Feb 4, 2014

Any idea when this is getting merged in?

@joelmoss
Copy link

An old issue, but I also need this please

@sergeiQ
Copy link

sergeiQ commented Jun 2, 2014

can someone merge it please?

@arulprasad
Copy link

+1

@zarry
Copy link
Contributor

zarry commented Aug 29, 2014

👍 want! Have this edited locally for now.

@jjasghar
Copy link
Contributor

This looks pretty straight forward, is it possible to write some Chefspec test(s) around this? It seems we are lacking them in this repo.

After that I'll merge this.

@jjasghar
Copy link
Contributor

Ok, scratch that, i'll just merge this.

jjasghar pushed a commit that referenced this pull request Nov 27, 2014
 expose the heartbeat configuration parameter
@jjasghar jjasghar merged commit a7d8f0a into rabbitmq:master Nov 27, 2014
@kisoku
Copy link
Author

kisoku commented Nov 27, 2014

I'd forgotten about this PR. Thanks!

@@ -90,6 +90,9 @@
default['rabbitmq']['erlang_cookie_path'] = '/var/db/rabbitmq/.erlang.cookie'
end

# heartbeat
default['rabbitmq']['heartbeat'] = 600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs the default is 580.

https://www.rabbitmq.com/configure.html

@jjasghar
Copy link
Contributor

I opened #170 to fix the default number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants