mnesia_to_khepri: Check MnesiaFun() return value for no_exists
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in addition to exceptions. [Why] `mnesia:transation/1` usually returns the reason a transaction was aborted. Throwing an exception was quite RabbitMQ-specific. [How] If we get a `no_exists` abort reason, we handle it the same way as if we got a `no_exists` exception.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 74.51% 73.96% -0.56%
==========================================
Files 13 13
Lines 624 630 +6
==========================================
+ Hits 465 466 +1
- Misses 159 164 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in addition to exceptions.
Why
mnesia:transation/1usually returns the reason a transaction was aborted. Throwing an exception was quite RabbitMQ-specific.How
If we get a
no_existsabort reason, we handle it the same way as if we got ano_existsexception.