Be more defensive when evaluating retention. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that osiris_log:evaluate_retention/1 may throw an error, in particular `missing_file` which could occur if an osiris member was deleted whilst an evaluation request was outstanding. Currently this crashes the evaluation process which isn't a big deal as it will restart but we'd lose any pending evaluation requests when this happen so it is better to try to avoid that.
michaelklishin
approved these changes
Jan 26, 2024
dumbbell
reviewed
Jan 26, 2024
Comment on lines
+79
to
+81
| catch _:Err -> | ||
| ?DEBUG_(Name, "retention evaluation failed with ~w", [Err]), | ||
| {noreply, State} |
There was a problem hiding this comment.
Are errors frequent here? If not, woult it be useful to also log the stacktrace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that osiris_log:evaluate_retention/1 may throw an error, in particular
missing_filewhich could occur if an osiris member was deleted whilst an evaluation request was outstanding.Currently this crashes the evaluation process which isn't a big deal
as it will restart but we'd lose any pending evaluation requests when this happen so it is better to try to avoid that.