osiris_log:overview/1 - fix crash with trailing empty index. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
osiris-log-overview-fixes-and-more
branch
from
ae1053d to
a11fd00
Compare
Also delete any segment files that do not have any index files that may have been caused by a process crash during retention deletion. Refactoring around file listings.
kjnilsson
force-pushed
the
osiris-log-overview-fixes-and-more
branch
from
a11fd00 to
320f5c9
Compare
michaelklishin
approved these changes
Aug 20, 2024
dumbbell
reviewed
Aug 20, 2024
kjnilsson
force-pushed
the
osiris-log-overview-fixes-and-more
branch
from
81f087b to
da891c4
Compare
Saibamen
reviewed
Aug 26, 2024
| is_file(File) -> | ||
| case prim_file:read_file_info(File) of | ||
| {ok, #file_info{type = directory}} -> | ||
| true; |
There was a problem hiding this comment.
Possibly. I cannot immediately think of a reason to treat directories as "files" here.
Note that this function is only used in one test in osiris_log_SUITE and it is used with a "regular" file.
There was a problem hiding this comment.
This function can be removed. Apart from being wrong it was copied from Ra and never really used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also delete any segment files that do not have any index files that may have been caused by a process crash during retention deletion.
See: rabbitmq/rabbitmq-server#12054
Refactoring around file listings.
Also a fix to segment counter after recovery with an empty log.