Emit the new local_query tuple only if query options are set
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why]
Using the new tuple isn't compatible with older versions of Ra. This
breaks local/leader queries if there are Ra members running an old
version.
[How]
We don't need the new `{local_query, QueryFun, Options}` tuple if there
is no options. We can use the old `{local_query, QueryFun}` in this case
and keep the compatibility.
dumbbell
force-pushed
the
emit-new-local_query-tuple-only-if-options-are-set
branch
from
5c4c204
to
26b0259
Compare
kjnilsson
approved these changes
Jul 8, 2024
|
I've set the milestone to |
michaelklishin
deleted the
emit-new-local_query-tuple-only-if-options-are-set
branch
|
That's correct, I don't think it requires a minor bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Using the new tuple isn't compatible with older versions of Ra. This breaks local/leader queries if there are Ra members running an old version.
How
We don't need the new
{local_query, QueryFun, Options}tuple if there is no options. We can use the old{local_query, QueryFun}in this case and keep the compatibility.