Avoid interrupting Ra system start when pre init fails #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
pre-init-missing-checkpoints-dir
branch
2 times, most recently
from
cea7b76
to
c925479
Compare
kjnilsson
changed the title
kjnilsson
changed the title
kjnilsson
force-pushed
the
pre-init-missing-checkpoints-dir
branch
2 times, most recently
from
c10f59b
to
5f73766
Compare
the-mikedavis
approved these changes
Jul 23, 2024
In practice this has proven too strict so now we will only log errors as they occur, not stop the pre-init process from completing. Also avoid asserting on a missing checkpoints directory as it isn't necessary and the next server start will take care of that.
kjnilsson
force-pushed
the
pre-init-missing-checkpoints-dir
branch
from
5f73766
to
b62b33d
Compare
the-mikedavis
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice this has proven too strict so now we will only log
errors as they occur, not stop the pre-init process from completing.
Also avoid asserting on a missing checkpoints directory as it isn't necessary
and the next server start will take care of that.