Amend ra_machine:snapshot_installed/4 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
snapshot-installed-4-tweaks
branch
from
1ec7d6a
to
051b5de
Compare
dumbbell
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Looks good to me. @the-mikedavis, could you please take a look as well?
the-mikedavis
approved these changes
Sep 4, 2024
the-mikedavis
requested changes
Sep 4, 2024
Instead of passing the plain old version we build a full snapshot meta so that we can also compare index, term and membership as well as the machine version. Changed the order of arguments. Removed the optional snapshot_installed/2 callback but retained the fallback call in ra_machine in case it is still implemented somwhere.
kjnilsson
force-pushed
the
snapshot-installed-4-tweaks
branch
from
051b5de
to
682947c
Compare
the-mikedavis
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing the plain old version we build a full snapshot meta so that we can also compare index, term and membership as well as the machine version.
Changed the order of arguments.
Removed the optional
snapshot_installed/2callback but retainedthe fallback call in ra_machine in case it is still implemented
somwhere.