This repository has been archived by the owner on Jan 20, 2025. It is now read-only.
Consul: allow clustering with nodes in warning status #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ValFadeev thank you! |
include/autocluster.hrl
Outdated
| @@ -28,6 +28,7 @@ | |||
| {config, cluster_name, "CLUSTER_NAME", "undefined", string, false}, %% Consul && etcd | |||
|
|
|||
| {config, consul_acl_token, "CONSUL_ACL_TOKEN", "undefined", string, false}, %% Consul | |||
| {config, consul_allow_warn, "CONSUL_ALLOW_WARN", false, atom, false}, | |||
There was a problem hiding this comment.
I'd like to find a more descriptive name. CONSUL_TOLERATE_WARN or CONSUL_ALLOW_WARN seem too short to me. It's not clear what are we allowing here.
I'd go with something like CONSUL_INCLUDE_NODES_WITH_WARNINGS. While longer, it is more or less to the point. WDYT?
There was a problem hiding this comment.
@michaelklishin agree, in hindsight the current name may also cause confusion with CLEANUP_WARN_ONLY option. Happy to go with the suggested name, as can't think of anything shorter to convey the meaning
* added filtering by health check status * added tests
Ensures consul calls include the filter, otherwise it might return unfiltered warnings
dcorbacho
force-pushed
the
consul-allow-warning
branch
from
edc0ee4 to
43045ea
Compare
dcorbacho
approved these changes
Apr 5, 2017
There was a problem hiding this comment.
Thanks @ValFadeev! It looks good, only added an additional test case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from aweber#140
Consul agent may be configured with additional health checks, besides the TTL one created by the plugin. Some of these checks may expect a converged cluster. If any of those additional checks is not passing the corresponding nodes will be excluded from the list for clustering which is not always the desired situation.
This change aims to provide flexibility to define additional health checks while avoiding interference with auto clustering. This is consistent with Consul's
only-passingoption which determines whether nodes with warning status are excluded from the DNS response.