Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo in comments of WaitForConfirmsOrDieAsync #1095

Merged

Conversation

ArminShoeibi
Copy link
Contributor

@ArminShoeibi ArminShoeibi commented Oct 3, 2021

Proposed Changes

WaitForConfirmsOrDieAsync:
Waits until all messages published since the last call have been ack'd by the
broker. If a nack is received or the timeout elapses, throws an OperationInterruptedException exception immediately.

/// elapses, throws an OperationInterruptedException exception immediately.

but this method throws an System.IO.IOException

lets reproduce this problem.
image

System.IO.IOException: Timed out waiting for acks
at RabbitMQ.Client.Impl.ModelBase.WaitForConfirmsOrDie(TimeSpan timeout)
at RabbitMQ.Client.Impl.AutorecoveringModel.WaitForConfirmsOrDie(TimeSpan timeout)
at CPR2.Api.RabbitMQPublishers.AvailableFlightsRequestPublisher.Publish(AvailableFlightsRequestProto message) in C:\CPR-Project\CPR2\src\CPR2.Api\RabbitMQPublishers\AvailableFlightsRequestPublisher.cs:line 94

thank you in advance.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@ArminShoeibi
Copy link
Contributor Author

hey @michaelklishin could you please check this PR?
Thank you.

@michaelklishin michaelklishin merged commit 22b16c9 into rabbitmq:main Oct 17, 2021
@ArminShoeibi ArminShoeibi deleted the fix/typo-publisher-confirms branch May 7, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants