Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify code around RabbitMQCtl #1111

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

bollhals
Copy link
Contributor

Proposed Changes

Simplifies the code around the RabbitMQCtl class by

  • Figuring out just once how to call rabbitmqctl
  • simplify regex for parsing pid / connection name for closing a single connection
  • read only the pid when closing all connections

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit 2f19d54 into rabbitmq:main Nov 22, 2021
@michaelklishin
Copy link
Member

Thank you!

@bollhals bollhals deleted the feature/rabbitmqctl branch November 24, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants