Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Task.WaitAsync() to cancel an await call #1206

Merged

Conversation

ArminShoeibi
Copy link
Contributor

@ArminShoeibi ArminShoeibi commented May 14, 2022

Proposed Changes

Hello there folks.
This pull request uses new APIs in the Task Class.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Thanks in advance.

@michaelklishin michaelklishin added this to the 7.0.0 milestone May 14, 2022
@michaelklishin michaelklishin merged commit c485343 into rabbitmq:main May 14, 2022
@ArminShoeibi ArminShoeibi deleted the arminshoeibi/use-WaitAsync-net6 branch May 14, 2022 08:50
michaelklishin added a commit that referenced this pull request May 14, 2022
michaelklishin added a commit that referenced this pull request May 15, 2022
(cherry picked from commit f90b9ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants