Fix consumer recovery with server-named queues #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
This looks reasonable but just for the record, in the Java client
we intentionally decided to recover server-named queues in a way
that gives them new server-generated names (which are then propagated to consumers/bindings).
That makes the implementation more complex but can also seem logical
to some users.
Fixes #1238 * Add failing test * Fix `RecordedConsumer` to allow the empty string for a queue name * Add `CurrentQueue` to `IModel` to keep track of the last declared queue name as defined in the AMQP 091 spec * Fix `RecordedConsumer` to use `CurrentQueue` when passed in name is `string.Empty` Fixup API Approval
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1238
branch
from
865dced to
7590feb
Compare
lukebakken
added a commit
that referenced
this pull request
Mar 23, 2023
Port of #1324 to main Fixes #1238 * Add failing test * Fix `RecordedConsumer` to allow the empty string for a queue name * Add `CurrentQueue` to `IChannel` to keep track of the last declared queue name as defined in the AMQP 091 spec * Fix `RecordedConsumer` to use `CurrentQueue` when passed in name is `string.Empty` * Fixup API Approval
Yep, that's exactly how it works here as well. Recovery creates new server-named queues and the new queue name is propagated to the correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1238
RecordedConsumerto allow the empty string for a queue name