Skip to content

Conversation

@evolvedlight
Copy link

Proposed Changes

This fixes #1370 by making a copy of the default auth mechanisms, rather than providing a reference to the static (shared) DefaultAuthMechansisms

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • [x ] Bug fix (non-breaking change which fixes issue ConnectionFactory Authmechanisms has incorrect sharing between instances #1370)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • [x ] I have read the CONTRIBUTING.md document
  • [x ] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • [x ] All tests pass locally with my changes
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@michaelklishin michaelklishin merged commit cfae9f5 into rabbitmq:6.x Aug 12, 2023
@michaelklishin
Copy link
Contributor

Thank you!

I cannot promise when the next 6.x release will go out but it should not take too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants