Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Moq #1393

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Remove use of Moq #1393

merged 3 commits into from
Sep 27, 2023

Conversation

lukebakken
Copy link
Contributor

Fixes #1369

@lukebakken lukebakken self-assigned this Sep 26, 2023
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1369 branch from 6f98341 to fde52a8 Compare September 26, 2023 21:32
@lukebakken lukebakken marked this pull request as ready for review September 26, 2023 21:32
@lukebakken lukebakken added this to the 7.0.0 milestone Sep 26, 2023
MarcialRosales
MarcialRosales reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@MarcialRosales MarcialRosales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukebakken , rather than implementing ourselves the mocking mechanism, would it make sense to use other library instead of Moq?

@michaelklishin
Copy link
Member

@MarcialRosales if you have a good alternative to suggest that does not collect telemetry data, sure.

@lukebakken
Copy link
Contributor Author

Hi @lukebakken , rather than implementing ourselves the mocking mechanism, would it make sense to use other library instead of Moq?

We can do that if the future need arises. For now, the amount of code that needs to be hand-written is small.

@lukebakken
Remove Moq
cbe5b73 
Fixes #1369

Use mock test objects instead of Moq

Use reset events rather than sleeps
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1369 branch from fde52a8 to cbe5b73 Compare September 27, 2023 13:18
@MarcialRosales
Copy link
Contributor

@michaelklishin , I will look into that . For now, https://www.libhunt.com/r/NSubstitute, looks like the best alternative.
@lukebakken , for the time being, we can live with a handcrafted mock.

@lukebakken lukebakken merged commit 55fc05a into main Sep 27, 2023
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1369 branch September 27, 2023 21:57
@lukebakken lukebakken mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcialRosales MarcialRosales MarcialRosales left review comments

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Remove the use of Moq
3 participants
@lukebakken @michaelklishin @MarcialRosales