Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Unix Time units in AmqpTimestamp #1407

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Oct 23, 2023

Proposed Changes

This improves the documentation of AmqpTimestamp to specify that Unix Time is in seconds. This is in the AMQP 0.9.1 spec at section 4,2.5.4, but having it in the code documentation makes it nicer to work with.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@pivotal-cla
Copy link

@ngbrown Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ngbrown Thank you for signing the Contributor License Agreement!

@michaelklishin michaelklishin merged commit a0321c6 into rabbitmq:main Oct 23, 2023
@lukebakken lukebakken self-assigned this Oct 24, 2023
@lukebakken lukebakken added this to the 7.0.0 milestone Oct 24, 2023
@ngbrown ngbrown deleted the ngbrown-patch-1 branch November 6, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants