Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in from async methods #1602

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Remove in from async methods #1602

merged 2 commits into from
Jun 14, 2024

Conversation

Tornhoof
Copy link
Contributor

@Tornhoof Tornhoof commented Jun 14, 2024

Proposed Changes

Remove the in modifier from async methods.
Mentioned the management plugin in the test documentation.
Closes #1601

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Some tests in SequentialIntegration fail locally with timeouts, e.g. Test.SequentialIntegration.TestConnectionRecovery.TestShutdownEventHandlersRecoveryOnConnectionAfterDelayedServerRestart [FAIL], the tests all time out.
These fail with the main branch too on my system, this does not appear to be related. Not sure what's wrong there.

I added a short addendum to the RUNNING_TESTS.md that it requires the management plugin, which is not strictly part of the default package, it needs to be enabled (at least on windows).

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukebakken lukebakken added this to the 7.0.0 milestone Jun 14, 2024
@lukebakken lukebakken self-assigned this Jun 14, 2024
@lukebakken lukebakken merged commit bf15067 into rabbitmq:main Jun 14, 2024
11 checks passed
@Tornhoof Tornhoof deleted the RemoveIn branch June 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with 7.0rc1 IAsyncBasicConsumer's method
2 participants