-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change InboundFrame to a class #1613
Conversation
@bollhals I converted this PR to a draft. Feel free to click "Ready for review" when you're done. Thank you for this contribution! |
It's ready. It was just some whitespace formatting issue. (My settings are different than what's expected here) |
* Improve `TakeoverPayload` * Use `RentedMemory` and define more constants * Use explicit types instead of `var`
85a6c09
to
004ce32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I will merge once CI passes and will release RC.3
Nice! |
Just FYI, I have currently a bit of spare time (again after some busy years^^) and plan to push a few updates. (Up to you to include it them in whatever version you see fit 👍 (Another RC or 7.x or even 8)) |
@bollhals thank you, I will keep an eye out. I would like to get version 7 released soon but am happy to wait on your contributions. |
Proposed Changes
Changes the InboundFrame to a class instead of a readonly struct. There's only ever one frame active per connection, hence it can be a class that is allocated once and then reused.
benefits
in
).Types of Changes
Checklist
CONTRIBUTING.md
documentFurther Comments
There's a bugfix in here as well, if wanted, I can submit that separately. see my comments.