Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DispatchConsumersAsyncEnabled property on IConnection (#1611) #1615

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Jun 27, 2024

  • Name new property DispatchConsumersAsyncEnabled.
  • Add a check on BasicConsume for when a regular dispatcher is used, and an async consumer passed.
  • Test the new DispatchConsumersAsyncEnabled property.

Follow-up to #1611
Fixes #1610

* Name new property `DispatchConsumersAsyncEnabled`.
* Add a check on `BasicConsume` for when a regular dispatcher is used, and an async consumer passed.
* Test the new `DispatchConsumersAsyncEnabled` property.
@lukebakken lukebakken self-assigned this Jun 27, 2024
@lukebakken lukebakken added this to the 7.0.0 milestone Jun 27, 2024
@lukebakken lukebakken marked this pull request as ready for review June 27, 2024 16:43
@lukebakken lukebakken merged commit 6673bd5 into main Jun 27, 2024
11 checks passed
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1611-followup branch June 27, 2024 16:44
@lukebakken
Copy link
Contributor Author

@luizcarlosfaria this API change will be available in version 7. Thanks!

@niemyjski
Copy link

This change is kind of confusing looking at the 7.0 breaking changes.

_factory = new ConnectionFactory
        {
            Uri = new Uri(options.ConnectionString),
            AutomaticRecoveryEnabled = true,
            DispatchConsumersAsync = true
        };
        ```
        
        DispatchConsumersAsync where did this get moved to now?

@lukebakken
Copy link
Contributor Author

@niemyjski would you mind starting a new discussion, or asking in this one, so other people can more easily find my response?

#1720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose ConnectionFactory.DispatchConsumersAsync as a ReadOnly property on IConnection
3 participants