Make connection events async

[danielmarbach]

Proposed Changes

Follow through on discussion in #1675 (comment)

@lukebakken mentioned his original intent was to make the events async across the board but stopped.

This PR would align the connection API surface

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

[lukebakken]

Thank you @danielmarbach, I will review this ASAP. Just FYI, I merged #1675 and rebased your PR branch on main.

[danielmarbach]

Once this one is in I can change the other events too if you'd like

[lukebakken]

Once this one is in I can change the other events too if you'd like

That would be great. From my attempt at doing this, I remember that it was the OnSessionShutdown event that, when made async, made everything go haywire in the test suite. That doesn't seem to be the case here (which is great).

[lukebakken]

Is now the time to add CancellationToken to the AsyncEventHandler delegate?

[danielmarbach]

Is now the time to add CancellationToken to the AsyncEventHandler delegate?

My plan was to sweep through that after all the events are changed to be async as a dedicated PR and not mix things

[danielmarbach]

Are you also adding the suffix to all the other events too?

[lukebakken]

Are you also adding the suffix to all the other events too?

Everything that has changed in this PR. I'll do a commit per-rename.

[lukebakken]

There is only one wrapper that is missing from this list (_consumerAboutToBeRecoveredAsyncWrapper). The other wrappers are in the AutorecoveringConnection class, which remains the same instance when a connection is recovered. The reason TakeOver is necessary is that the inner Connection instance is a new one during connection recovery.

[lukebakken]

Renames are complete, I'll merge this once CI passes. Thanks!

[danielmarbach]

Raised the PR for the session event #1679