#706 Pipelines implementation and allocation improvements (master rebase) #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he pipes and using pooled buffers for inbound frames.
…ask that's only triggered when needed.
Adding ArrayPool and RecyclableMemoryStream. Adding Pipeline support. Allocations pretty much constant now, as we are writing directly to the pipes and using pooled buffers for inbound frames. All tests except ApiApproval now run. Allocations severely reduced. Removing additional debug symbols. Improving the connection logic. Optimizing the multiple-confirm logic, pulling it out into it's own task that's only triggered when needed.
This was referenced Feb 6, 2020
Contributor
|
Been quite busy lately with other projects, but I'll start reviewing this very soon :) |
Collaborator
Author
|
@stebet no worries! This is targeted for 7.0 now so there is no rush. |
Contributor
|
I'll probably abandon this as #732 progresses and then pull the Pipelines implementation into it's own PR for 7.0.0 (with a few added things such as Task optimizations and concurrency fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #706 rebased on
masteras of just now. Opening this PR to trigger a CI build.