Skip to content

Conversation

@lukebakken
Copy link
Collaborator

Remove copied-in code

Pinging @bording

Remove copied-in code

Pinging @bording
@lukebakken lukebakken added this to the 6.0.0 milestone Feb 14, 2020
@lukebakken lukebakken self-assigned this Feb 14, 2020
@lukebakken
Copy link
Collaborator Author

Let's see if this survives a CI run...

@bording
Copy link
Collaborator

bording commented Feb 14, 2020

Looks like the changes to the approval file is all just some sorting differences, which is to be expected.

Looking at the size of the file, it would still be a really good idea to go through the types in the project and change the accessibility of most them to internal, which would make the file be a true representation of the public API surface.

@lukebakken
Copy link
Collaborator Author

lukebakken commented Feb 14, 2020

it would still be a really good idea to go through the types in the project and change the accessibility of most them to internal

A lot of that has been done in master already, with more to be done post 6.0. I'm probably not going to do that for 5.x because I don't want to screw something up.

@bording
Copy link
Collaborator

bording commented Feb 14, 2020

A lot of that has been done in master already, with more to be done post 6.0. I'm probably not going to do that for 5.x because I don't want to screw something up.

Sure, those kind of changes need to be done in a major. This PR is against master which is why I brought it up here.

@lukebakken
Copy link
Collaborator Author

@bording if you have time to "internalize" or "privatize" more parts of the public API prior to version 6.0, that would be great. I can't really get to that until I get 5.2.0 out the door.

@lukebakken lukebakken merged commit 46123c4 into master Feb 18, 2020
@lukebakken lukebakken deleted the lrb-use-publicapigenerator-project branch February 18, 2020 16:52
@bording
Copy link
Collaborator

bording commented Feb 18, 2020

@lukebakken I'll see what I can do. I am going out of town this week, so I might not have time until next week.

lukebakken added a commit that referenced this pull request Feb 19, 2020
Update to PublicApiGenerator 10.0.2

(cherry picked from commit 46123c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants