Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yield to prevent deadlocks #760

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Yield to prevent deadlocks #760

merged 1 commit into from
Mar 17, 2020

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Mar 16, 2020 •
edited
Loading

Based on this comment by @danielmarbach:

So the solution here is to do a Yield at the beginning of the event handler or for safety precaution reasons it would be possible to modify to Work class to do it uniformly

Fixes #341

@lukebakken
Yield to prevent deadlocks
77eb7f5 
Based on this comment by @danielmarbach:

> So the solution here is to do a Yield at the beginning of the event handler or for safety precaution reasons it would be possible to modify to Work class to do it uniformly
@lukebakken lukebakken self-assigned this Mar 16, 2020
@lukebakken lukebakken added this to the 6.0.0 milestone Mar 16, 2020
@lukebakken lukebakken requested a review from kjnilsson March 17, 2020 00:24
@danielmarbach
Copy link
Collaborator

For reference my initial comment still holds

Another reason why the client should be async all the way and not a weird mixture of both.

but I guess this is a necessary evil workaround

@lukebakken lukebakken added the next-gen-todo If a rewrite happens, address this issue. label Mar 17, 2020
@lukebakken
Copy link
Contributor Author

Thanks @danielmarbach for your review. Yes we plan on addressing this issue with version 7.0.0

@lukebakken lukebakken merged commit 924003e into master Mar 17, 2020
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-341-Task_Yield branch March 17, 2020 16:12
@lukebakken lukebakken mentioned this pull request May 31, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmarbach danielmarbach danielmarbach approved these changes

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

@kjnilsson kjnilsson Awaiting requested review from kjnilsson

Assignees

@lukebakken lukebakken

Labels
effort-tiny enhancement next-gen-todo If a rewrite happens, address this issue.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

BasicCancel hangs when using new async consumer
2 participants
@lukebakken @danielmarbach