Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unnecessary yield #900

Closed
wants to merge 1 commit into from

Conversation

danielmarbach
Copy link
Collaborator

Proposed Changes

As by my original comment #855 (comment)

I thought it was fixed by #863 but somehow it wasn't on 6.x. In case it was missed here is the PR

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

@stebet
Copy link
Contributor

stebet commented Jul 7, 2020

Whoopsie @danielmarbach, seems like a bunch of Rider specific project files snuck in there :)

@michaelklishin
Copy link
Member

This has an .cs.orig file committed together with IDEA (Rider?) files. I'll assume we only want a single file change here so this should be re-submitted?

@danielmarbach
Copy link
Collaborator Author

Why did you close this PR? I just did a force push, now I need to reopen...

@danielmarbach
Copy link
Collaborator Author

#901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants