Add FxCop with only ConfigureAwait rule enabled for now #932
Conversation
|
Travis CI is failing due to not being able to fetch some erlang stuff |
| @@ -4,6 +4,7 @@ | |||
| <TargetFrameworks>net461;netcoreapp3.1</TargetFrameworks> | |||
| <AssemblyOriginatorKeyFile>../rabbit.snk</AssemblyOriginatorKeyFile> | |||
| <SignAssembly>true</SignAssembly> | |||
| <RunAnalyzersDuringBuild>false</RunAnalyzersDuringBuild> | |||
There was a problem hiding this comment.
@danielmarbach why is this required? I see that no analyzers are installed in this project, nor in the parent Directory.Build.targets. Or is there a transitive dependency somewhere?
There was a problem hiding this comment.
Without the flag in VS
There was a problem hiding this comment.
It is related to PrivateAssets="None". If switched to All we can remove the exclusion from analysis
There was a problem hiding this comment.
PrivateAssets="None"
👍 yes, that explains it.
|
I have no idea anymore. Without this I got warning in test project automatically because Fxcop seemed to be loaded fully and analysing all assemblies. At least this is how it was locally at that time in Rider. I can try to remove it again when I have time at some point if anybody cares |
Proposed Changes
Fixes #917
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments