-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0: update target framework from net461 to netcoreapp3.1 #971
Conversation
@@ -28,6 +28,7 @@ | |||
<PackageOutputPath>..\..\packages</PackageOutputPath> | |||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
<CodeAnalysisRuleSet>RabbitMQ.ruleset</CodeAnalysisRuleSet> | |||
<LangVersion>latest</LangVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not set the language version to latest. Because that allows you to use language features that might not be supported by the TFMs chosen here. If you leave it blank you get automatically the proper language version supported by the TFM intersection
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't "The compiler accepts syntax from the latest released version of the compiler" mean it will always choose the latest possible whatever framework version we selected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will choose the the latest version the compiler knows about, overriding the version that would have been picked by the compiler based on the TFM.
@danielmarbach is right that it should not be set to get the automatic behavior that we want here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's wrong then, sorry. I'll update it in one of my next PRs. Thanks for the review
@bollhals I failed to backport this to |
Proposed Changes
7.0 Change
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
CONTRIBUTING.md
document