Make socket connection to try all DNS record IPs

[ebuildy]

In a HA RabbitMQ cluster, I use DNS round robin technic to load balance the load between nodes and replace HAProxy, for instance:

rabbitmq => 10.0.0.1 10.0.0.2 10.0.0.3

It works like a charm with the Php extension, because here:

https://github.com/alanxz/rabbitmq-c/blob/master/librabbitmq/amqp_socket.c#L449

We can see that all IP adresses from DNS record are "tested", so if a node goes down, no problemo, no error on Php side when connecting.

But, I also use logstash to consume RabbitMQ messages, which uses this library, and apparently, this little trick is not working as I can see on:

https://github.com/rabbitmq/rabbitmq-java-client/blob/master/src/main/java/com/rabbitmq/client/impl/FrameHandlerFactory.java#L28

Do you think this could be a feature here (or I may miss a Java trick here) ?

Thanks you,

[michaelklishin]

It's worth investigating if this client could do a similar thing.

[acogoluegnes]

@ebuildy Maybe this can be achieved with a custom implementation of the interface introduced in #169

[ebuildy]

Yeah ! Looks pretty good, thanks, i will work on the logstash plugin to
implement this .

Le 22 août 2016 4:56 PM, "Arnaud Cogoluègnes" notifications@github.com a
écrit :

@ebuildy https://github.com/ebuildy Maybe this can be achieved with a
custom implementation of the interface introduced in #169
#169

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#138 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKc6W-YFQiyZZlNM7_hXI02vjuUzkOpks5qibiugaJpZM4H7gm2
.

[michaelklishin]

@ebuildy to make it clear that we would be interested in making this a core feature but would like to understand how exact you would like it to work. Given that this is an interface that can have multiple implementations, the risk for us in including something in the core is quite low.

[acogoluegnes]

@ebuildy your changes could actually be in a custom implementation of AddressResolver. That would leave the FrameHandlerFactory unchanged.

[michaelklishin]

This feature has an unfortunate side-effect: it makes peer verification (as in TLS) based on hostname comparison next to impossible to do in many environments.

We will disable this resolver by default in a future 4.x and 5.x minor releases and not use it by default as of 6.0. It's a nice feature but TLS peer verification is a lot more popular and arguably important.