Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue names longer than 255 characters should be rejected early #72

Closed
garyrussell opened this issue Jun 28, 2015 · 2 comments
Closed

Queue names longer than 255 characters should be rejected early #72

garyrussell opened this issue Jun 28, 2015 · 2 comments
Assignees
@michaelklishin
Labels
bug effort-tiny usability
Milestone
3.5.4

Comments

@garyrussell
Copy link
Contributor

See https://groups.google.com/forum/#!topic/rabbitmq-users/0i22nvdfP-M

When a queue name exceeds 255 chars, an IllegalArgumentException is thrown but the channel is not closed; the next operation on the channel hangs.
@garyrussell garyrussell changed the title Channel Hangs After declareQueue Illegal Argument Channel Hangs After queueDeclare Illegal Argument Jun 28, 2015
@michaelklishin michaelklishin self-assigned this Jun 28, 2015
@michaelklishin michaelklishin added this to the 3.5.4 milestone Jun 28, 2015
@michaelklishin
Copy link
Member

So sounds like we should reject names longer than the spec-dictated limit and not send anything, so the channel remains open. How does that sound @garyrussell?

@garyrussell
Copy link
Contributor Author

Yes, that would work - detect the illegal argument sooner.

@michaelklishin michaelklishin changed the title Channel Hangs After queueDeclare Illegal Argument Queue names longer than 255 characters should be rejected early Jun 28, 2015
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 28, 2015
@garyrussell
AMQP-508: Queue Declaration IllegalArgumentExcept.
b96ebe4 
JIRA: https://jira.spring.io/browse/AMQP-508

Workaround for rabbitmq/rabbitmq-java-client#72
@garyrussell garyrussell mentioned this issue Jun 28, 2015
Closed
michaelklishin added a commit that referenced this issue Jun 28, 2015
@michaelklishin
Throw IllegalArgumentError early if queue name length exceeds 255 chars
57f1ead 
Fixes #72.
@michaelklishin michaelklishin mentioned this issue Jun 28, 2015
Merged
garyrussell added a commit to spring-projects/spring-amqp that referenced this issue Jun 29, 2015
@garyrussell @artembilan
AMQP-508: Queue Declaration IllegalArgumentExcept.
344fcb9 
JIRA: https://jira.spring.io/browse/AMQP-508

Workaround for rabbitmq/rabbitmq-java-client#72
artembilan pushed a commit to artembilan/spring-amqp that referenced this issue Jun 29, 2015
@garyrussell @artembilan
AMQP-508: Queue Declaration IllegalArgumentExcept.
96845a7 
JIRA: https://jira.spring.io/browse/AMQP-508

Workaround for rabbitmq/rabbitmq-java-client#72
stream-iori pushed a commit to stream-iori/rabbitmq-java-client that referenced this issue Mar 20, 2022
@alaneuler
SOFA thread implementation refines and readme re-write (rabbitmq#72)
acd9ec4 
* thread pool print simplify
focbenz added a commit to focbenz/rabbitmq-java-client that referenced this issue May 6, 2022
@focbenz
Update README.md with AL 2.0
09afe12 
Following [PR rabbitmq#72](rabbitmq#772) shortened the Apache License, Version 2.0 to "AL":

The Apache License, 2.0 should be abbreviated as AL instead of ASL. (https://www.apache.org/licenses/LICENSE-2.0)

Only the version 1.1 was known as Apache Software License 1.1, however, AL 2.0 can also be used for non-software. To avoid any confusion (e.g. in downstream licence checks), the abbreviation should be kept consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
bug effort-tiny usability
Projects
None yet
Milestone
3.5.4
Development

No branches or pull requests
2 participants
@michaelklishin @garyrussell