Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excludeQueueFromRecovery method #346

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Add excludeQueueFromRecovery method #346

merged 3 commits into from
Jan 17, 2018

Conversation

vikinghawk
Copy link
Contributor

Proposed Changes

See #345 for details. As requested creating this new PR on 4.x.x branch. Renamed method and added test,

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@michaelklishin michaelklishin merged commit 1238701 into rabbitmq:4.x.x-stable Jan 17, 2018
@michaelklishin
Copy link
Member

Thank you!

@vikinghawk
Copy link
Contributor Author

do you guys have any estimate on when this and #343 might be released on 4.x?

Its not super urgent, but would be much appreciated by either 2/6 or 3/6 so we can get it into one of our next releases. Thanks!

@michaelklishin
Copy link
Member

Within a week sounds doable.

@acogoluegnes acogoluegnes added this to the 4.5.0 milestone Jan 24, 2018
@acogoluegnes
Copy link
Contributor

@vikinghawk 4.5.0.RC1 has just been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants