This repository was archived by the owner on Nov 16, 2020. It is now read-only.
Option to disable metrics collector on startup #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows external stats to be gathered for the prometheus plugin, while removing all metrics collection/aggregation and unnecesary management services. To disable set app env `disable_metrics_collector` to `true`. Defaults `false` [#164376052]
Merged
11 tasks
gerhard
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Given the following rabbitmq.conf
management_agent.disable_metrics_collector = true
Only rabbit_mgmt_external_stats will be started:
This is what the process tree looks like without the above config setting:
The metrics made available by rabbitmq_prometheus are the same in both cases.
gerhard
added a commit
to rabbitmq/rabbitmq-prometheus
that referenced
this pull request
Apr 22, 2019
This has support for disabling metrics_collector, as captured in rabbitmq/rabbitmq-management-agent#78 & rabbitmq/rabbitmq-management#691 Since we want management to be enabled, this doesn't help our use-case, but this option is perfect for users that want metrics, but don't want to pay the overhead of Management - especially metric aggregations. [#164376052]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows external stats to be gathered for the prometheus plugin, while
removing all metrics collection/aggregation and unnecesary management
services.
To disable set app env
disable_metrics_collectortotrue.Defaults
false[#164376052]