Skip to content

During definition import, Shovel startup can race with queue startup #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelklishin opened this issue Feb 8, 2021 · 0 comments
Closed
Assignees
Milestone

Comments

@michaelklishin
Copy link
Collaborator

Currently a definition file with quorum queues and dynamic Shovels that rely on those queues and use queue destination can be imported with confusing results: the queues will be imported concurrently with the shovels, and the shovels may end up "winning" the race and declare their queues. Due to #2798, there is no way to make a dynamic Shovel declare a quorum queue, so the queues can end up being of the wrong type.

There are two fundamental solutions that do not tie Shovel startup to the process of definition import in the core:

However, we can move runtime parameter and policy import step after the queue (topology) import step and reduce the likelihood of confusion.

@michaelklishin michaelklishin added this to the 3.8.12 milestone Feb 8, 2021
@michaelklishin michaelklishin self-assigned this Feb 8, 2021
michaelklishin added a commit that referenced this issue Feb 9, 2021
To reduce the likelihood of Shovel startup racing with
queue startup. See #2799 for details.

Closes #2799 for details.

(cherry picked from commit 83e3f75)
michaelklishin added a commit that referenced this issue Feb 25, 2021
To reduce the likelihood of Shovel startup racing with
queue startup. See #2799 for details.

Closes #2799 for details.

(cherry picked from commit 83e3f75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant