Skip to content

Presence server #10065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Presence server #10065

wants to merge 5 commits into from

Conversation

kjnilsson
Copy link
Contributor

This adds a simple presence server on each rabbit node that sends heartbeats to all other configred rabbbit nodes and maintains a local view of which peers are present.

This can be used to get the list of present nodes for functions where it is more important to return a result than to be 100% correct (which is very hard anyway).

Proposed Changes

Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much lower chance of being accepted.

If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@mergify mergify bot added the bazel label Dec 7, 2023
This adds a simple presence server on each rabbit node that
sends heartbeats to all other configred rabbbit nodes and maintains
a local view of which peers are present.

This can be used to get the list of present nodes for functions where
it is more important to return a result than to be 100% correct
(which is very hard anyway).

remove logs

fix

maybe

maybe
@kjnilsson kjnilsson added this to the 4.0.0 milestone Jan 26, 2024
@MirahImage MirahImage removed this from the 4.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants