Native Elixir support in Erlang.mk (SEE DESCRIPTION BEFORE MERGE) #12922
+974
−4,025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-native-elixir
branch
3 times, most recently
from
727002a to
08d1e10
Compare
This comment was marked as outdated.
This comment was marked as outdated.
michaelklishin
changed the title
lhoguin
force-pushed
the
loic-native-elixir
branch
from
7380de3 to
e921674
Compare
This avoids using Mix while compiling which simplifies a number of things and let us do further build improvements later on. This commit also includes a few changes that are related: * The Erlang distribution will now be started for parallel-ct * Many unnecessary PROJECT_MOD lines have been removed * `eunit_formatters` has been removed, it provides little value * The new `maybe_flock` Erlang.mk function is used where possible
lhoguin
force-pushed
the
loic-native-elixir
branch
from
3d491c9 to
140ebcd
Compare
lhoguin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would recommend not merging this until after 4.1 is released, or at least to keep this in
main.The related Erlang.mk PR is at ninenines/erlang.mk#1020 and is currently not merged, therefore the Erlang.mk in this PR is experimental. It would be good to have some feedback before merging into Erlang.mk, and RabbitMQ
mainis a good candidate for that as it has a low impact compared to release branches.