Update Cowboy #13242
Merged
Update Cowboy #13242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-update-cowboy-2025
branch
2 times, most recently
from
f40d4e3 to
376355a
Compare
Cowboy 2.13 contains the Websocket optimisations as well as the ability to set the Websocket max_frame_size option dynamically, plus plenty of other improvements. Cowlib was added as a test dep to rabbitmq_mqtt to make sure emqtt doesn't pull the wrong Cowlib version for Cowboy.
lhoguin
force-pushed
the
loic-update-cowboy-2025
branch
from
376355a to
3e00c84
Compare
|
The key changes with regard to RabbitMQ are greatly improved Websocket performance, as well as good HTTP performance improvements. This also includes a way to dynamically set https://ninenines.eu/articles/cowboy-2.13.0-performance/ |
|
@Mergifyio backport v4.1.x |
✅ Backports have been created
|
lhoguin
added a commit
that referenced
this pull request
Feb 18, 2025
Update Cowboy (backport #13242)
ansd
added a commit
that referenced
this pull request
Feb 18, 2025
Since #13242 updated Cowlib to v2.14.0, this commit deletes rabbit_uri as written in the comments of rabbit_uri.erl: ``` This file is a partial copy of https://github.com/ninenines/cowlib/blob/optimise-urldecode/src/cow_uri.erl We use this copy because: 1. uri_string:unquote/1 is lax: It doesn't validate that characters that are required to be percent encoded are indeed percent encoded. In RabbitMQ, we want to enforce that proper percent encoding is done by AMQP clients. 2. uri_string:unquote/1 and cow_uri:urldecode/1 in cowlib v2.13.0 are both slow because they allocate a new binary for the common case where no character was percent encoded. When a new cowlib version is released, we should make app rabbit depend on app cowlib calling cow_uri:urldecode/1 and delete this file (rabbit_uri.erl). ```
Merged
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
Since #13242 updated Cowlib to v2.14.0, this commit deletes rabbit_uri as written in the comments of rabbit_uri.erl: ``` This file is a partial copy of https://github.com/ninenines/cowlib/blob/optimise-urldecode/src/cow_uri.erl We use this copy because: 1. uri_string:unquote/1 is lax: It doesn't validate that characters that are required to be percent encoded are indeed percent encoded. In RabbitMQ, we want to enforce that proper percent encoding is done by AMQP clients. 2. uri_string:unquote/1 and cow_uri:urldecode/1 in cowlib v2.13.0 are both slow because they allocate a new binary for the common case where no character was percent encoded. When a new cowlib version is released, we should make app rabbit depend on app cowlib calling cow_uri:urldecode/1 and delete this file (rabbit_uri.erl). ``` (cherry picked from commit 2350299)
ansd
added a commit
that referenced
this pull request
Feb 18, 2025
Since #13242 updated Cowlib to v2.14.0, this commit deletes rabbit_uri as written in the comments of rabbit_uri.erl: ``` This file is a partial copy of https://github.com/ninenines/cowlib/blob/optimise-urldecode/src/cow_uri.erl We use this copy because: 1. uri_string:unquote/1 is lax: It doesn't validate that characters that are required to be percent encoded are indeed percent encoded. In RabbitMQ, we want to enforce that proper percent encoding is done by AMQP clients. 2. uri_string:unquote/1 and cow_uri:urldecode/1 in cowlib v2.13.0 are both slow because they allocate a new binary for the common case where no character was percent encoded. When a new cowlib version is released, we should make app rabbit depend on app cowlib calling cow_uri:urldecode/1 and delete this file (rabbit_uri.erl). ``` (cherry picked from commit 2350299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.