Adds error message for list_user_permissions missing argument #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -519,6 +519,9 @@ action(list_vhosts, Node, Args, _Opts, Inform, Timeout) -> | |||
| display_info_list(call(Node, {rabbit_vhost, info_all, []}, Timeout), | |||
| ArgAtoms); | |||
|
|
|||
| action(list_user_permissions, _Node, _Args = [], _Opts, _Inform, _Timeout) -> | |||
There was a problem hiding this comment.
Perhaps Args = [""] could be caught here as well?
I'm thinking of scripts calling rabbitmqctl list_user_permissions "$user" but $user is not set.
There was a problem hiding this comment.
wouldn't the empty string be a problem with most commands actually? I think for that case we get an error like this:
Listing permissions for user [] ...
Error: no_such_user:
which at least tells me something about the problem, not like function_clause before
There was a problem hiding this comment.
Yes, if we want to handle empty values, it needs to be a separate issue (not sure how many run into that).
There was a problem hiding this comment.
Ok, the current error is fine. Disregard my comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183