Optimise MQTT state machine #2692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was particularly slow when processing down commands.
michaelklishin
approved these changes
Dec 21, 2020
michaelklishin
added a commit
that referenced
this pull request
Dec 21, 2020
Optimise MQTT state machine (cherry picked from commit de02be2)
Collaborator
|
Backported to |
Contributor
|
didn't go so well starting with an existing mnesia directory, which had run the previous fix: starting a clean server seems to work well though |
Contributor
Author
|
oh bother, I just realised I broke backwards compatibility. @michaelklishin we're going to have to remove the backport until I can fix this. |
Contributor
Author
|
@carlhoerberg I've created a new PR #2693 that includes backwards compatibility. I'm still testing this but we'd welcome more testing of course. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was particularly slow when processing down commands.
See: #2688