Skip to content

Conversation

@HoloRin
Copy link
Contributor

@HoloRin HoloRin commented Apr 7, 2021

Proposed Changes

Adds the necessary files for building and testing with Bazel. This is a backport of the changes in master.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

HoloRin added 23 commits April 7, 2021 16:35
Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang
- no need to test version of ra since +debug_info is now default
- adjust the way default erlc_opts are handled
This suite contains only one group, but is long enough to warrant
sharding. This is probably a bit of a time penalty in absolute terms
because init_per_suite and init_per_group re-run in each shard.
requires recent @bazel-erlang updates
by using the GitHub Actions worker itself. Also make such builds NOT public
in buildbuddy (I plan to uses these for tests that inject AWS creds)
@HoloRin HoloRin marked this pull request as ready for review April 7, 2021 15:24
@HoloRin HoloRin merged commit 385325a into v3.8.x Apr 7, 2021
@HoloRin HoloRin deleted the bazel-v3.8.x branch April 7, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants