QQ: stability and channel side improvements #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
changed the title
kjnilsson
changed the title
kjnilsson
changed the title
kjnilsson
changed the title
kjnilsson
force-pushed
the
qq-register-enqueuer-reliability
branch
from
dd880aa to
0141745
Compare
mkuratczyk
approved these changes
Nov 8, 2021
Contributor
mkuratczyk
left a comment
mkuratczyk
left a comment
There was a problem hiding this comment.
I can no longer reproduce the failures we wanted to address.
This should avoid channel crashes when the leader has recently changed and the amqqueue record hasn't yet been updated. Also catch errors in the QQ tick temporary process that updates metrics. During shutdown the metrics ETS table may disappear before this process has finished which would result in a noisy error in the logs.
In a function called if a queue declare returns 'absent'.
Refactor how the single active consumer check is performed when consuming. Improve timeouts in rabbit_fifo_client.
kjnilsson
force-pushed
the
qq-register-enqueuer-reliability
branch
2 times, most recently
from
f52f287 to
3d7edce
Compare
kjnilsson
changed the title
kjnilsson
changed the title
michaelklishin
added a commit
that referenced
this pull request
Nov 8, 2021
QQ: stability and channel side improvements (backport #3628)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid channel crashes when the leader has recently changed
and the amqqueue record hasn't yet been updated.
Also catch errors in the QQ tick temporary process that updates metrics.
During shutdown the metrics ETS table may disappear before this process has finished
which would result in a noisy error in the logs.
Also handle case where a QQ "pid" was passed to a function expecting an actual pid.