Turn down logging from queue rebalancing #3643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With many queues, rebalancing can log hundreds of lines at warning/info level, even though nothing exciting happened. I think we can tune that down - if there is nothing to do - that's a debug level, if things go well - that's info, not a warning.
michaelklishin
approved these changes
Nov 3, 2021
michaelklishin
added a commit
that referenced
this pull request
Nov 3, 2021
Turn down logging from queue rebalancing (backport #3643)
michaelklishin
added a commit
that referenced
this pull request
Nov 3, 2021
Turn down logging from queue rebalancing (cherry picked from commit 8827d51) Conflicts: deps/rabbit/src/rabbit_amqqueue.erl
Collaborator
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With many queues, rebalancing can log hundreds of lines at warning/info
level, even though nothing exciting happened. I think we can tune that
down - if there is nothing to do - that's a debug level,
if things go well - that's info, not a warning.
I labeled it for backporting to 3.8 and 3.9 but feel free to change that.