Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use various modern dotnet build files #253

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Use various modern dotnet build files #253

merged 1 commit into from
Mar 17, 2023

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Mar 13, 2023 •
edited
Loading

@lukebakken lukebakken self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (8950faa) 93.02% compared to head (a4238a8) 93.02%.

❗ Current head a4238a8 differs from pull request most recent head 10fb9b0. Consider uploading reports for the commit 10fb9b0 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         102      102           
  Lines        8725     8725           
  Branches      673      673           
=======================================
  Hits         8116     8116           
  Misses        471      471           
  Partials      138      138

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukebakken lukebakken added this to the 1.3.0 milestone Mar 13, 2023
@lukebakken lukebakken force-pushed the lukebakken/modern-dotnet-build branch from 96e32b6 to c32e2b5 Compare March 13, 2023 16:45
@lukebakken lukebakken requested a review from Gsantomaggio March 14, 2023 22:03
@lukebakken lukebakken marked this pull request as ready for review March 14, 2023 22:03
lukebakken
lukebakken commented Mar 14, 2023
View reviewed changes
.github/workflows/build-test.yaml
- name: Verify
run: dotnet format --no-restore --verbosity=diagnostic --verify-no-changes
run: dotnet format ./rabbitmq-stream-dotnet-client.sln --no-restore --verbosity=diagnostic --verify-no-changes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI dotnet format does not yet support Traversal projects.

@lukebakken lukebakken force-pushed the lukebakken/modern-dotnet-build branch from c32e2b5 to 10fb9b0 Compare March 14, 2023 22:13
Zerpet
Zerpet approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modern and fancy!

Should we wait on #250, in case this causes merge conflicts?
My reasoning is that #250 might be harder to adapt/rebase on top of this PR.

@lukebakken
Copy link
Contributor Author

I will merge this into #250. Thanks @Zerpet

@lukebakken lukebakken merged commit 10cd0c9 into main Mar 17, 2023
@lukebakken lukebakken deleted the lukebakken/modern-dotnet-build branch March 17, 2023 14:16
@lukebakken lukebakken mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet approved these changes

@Gsantomaggio Gsantomaggio Awaiting requested review from Gsantomaggio

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @Zerpet