Improve the rawProducer and rawSuperStreamProducer status #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pr is part of #336 the aim is to standardise the behaviour. - Add AlreadyClosedException when a producer or super stream producer is closed In the same way like AMQP does with channels - Producer: Flush the pending messages when closed. - Producer: Add AlreadyClosedException when closed. So it is the same like: AMQP and RawProducer and RawSuperStreamProducer - Improve IsAKnownException function with the AggregateException that can contains known exceptions needed for reconnect the client - Add EntitiesStateTests to test all the status and verify that all the entities have the same behaviour Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 93.00% 92.75% -0.25%
==========================================
Files 115 116 +1
Lines 10845 10952 +107
Branches 878 893 +15
==========================================
+ Hits 10086 10159 +73
- Misses 570 597 +27
- Partials 189 196 +7 ☔ View full report in Codecov by Sentry. |
Zerpet
previously approved these changes
Dec 20, 2023
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Zerpet
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr is part of #336 the aim is to standardise the behaviour.
Add AlreadyClosedException when a producer or super stream producer is closed In the same way like AMQP does with channels
Producer: Flush the pending messages when closed.
Producer: Add AlreadyClosedException when closed. So it is the same like: AMQP and RawProducer and RawSuperStreamProducer
Improve IsAKnownException function with the AggregateException that can contains known exceptions needed for reconnect the client
Add EntitiesStateTests to test all the status and verify that all the entities have the same behaviour