Skip to content

Commit

Permalink
Remove deprecated Netty-related settings
Browse files Browse the repository at this point in the history
Fixes #376
  • Loading branch information
acogoluegnes committed Jul 6, 2023
1 parent e7ae0d2 commit d568d72
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 93 deletions.
39 changes: 0 additions & 39 deletions src/main/java/com/rabbitmq/stream/ChannelCustomizer.java

This file was deleted.

33 changes: 0 additions & 33 deletions src/main/java/com/rabbitmq/stream/EnvironmentBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -187,39 +187,6 @@ public interface EnvironmentBuilder {
*/
EnvironmentBuilder requestedMaxFrameSize(int requestedMaxFrameSize);

/**
* The Netty {@link EventLoopGroup} instance to use.
*
* <p>The environment uses its own instance by default. It is the developer's responsibility to
* close the {@link EventLoopGroup} they provide.
*
* @param eventLoopGroup
* @return this builder instance
* @deprecated use {@link NettyConfiguration#eventLoopGroup(EventLoopGroup)} from {@link #netty()}
* instead
*/
EnvironmentBuilder eventLoopGroup(EventLoopGroup eventLoopGroup);

/**
* Netty's {@link io.netty.buffer.ByteBuf} allocator.
*
* @param byteBufAllocator
* @return this builder instance
* @deprecated use {@link NettyConfiguration#byteBufAllocator(ByteBufAllocator)} from {@link
* #netty()} instead
*/
EnvironmentBuilder byteBufAllocator(ByteBufAllocator byteBufAllocator);

/**
* An extension point to customize Netty's {@link io.netty.channel.Channel}s used for connection.
*
* @param channelCustomizer
* @return this builder instance
* @deprecated use {@link NettyConfiguration#channelCustomizer(Consumer)} from {@link #netty()}
* instead
*/
EnvironmentBuilder channelCustomizer(ChannelCustomizer channelCustomizer);

/**
* The checksum strategy used for chunk checksum.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,26 +134,12 @@ public EnvironmentBuilder compressionCodecFactory(
return this;
}

@SuppressWarnings("deprecation")
@Override
public EnvironmentBuilder eventLoopGroup(EventLoopGroup eventLoopGroup) {
this.netty().eventLoopGroup(eventLoopGroup);
return this;
}

@Override
public EnvironmentBuilder id(String id) {
this.id = id;
return this;
}

@SuppressWarnings("deprecation")
@Override
public EnvironmentBuilder byteBufAllocator(ByteBufAllocator byteBufAllocator) {
this.netty().byteBufAllocator(byteBufAllocator);
return this;
}

@Override
public EnvironmentBuilder rpcTimeout(Duration timeout) {
this.clientParameters.rpcTimeout(timeout);
Expand Down Expand Up @@ -195,13 +181,6 @@ public StreamEnvironmentBuilder requestedMaxFrameSize(int requestedMaxFrameSize)
return this;
}

@SuppressWarnings("deprecation")
public StreamEnvironmentBuilder channelCustomizer(
com.rabbitmq.stream.ChannelCustomizer channelCustomizer) {
this.netty().channelCustomizer(ch -> channelCustomizer.customize(ch));
return this;
}

public StreamEnvironmentBuilder chunkChecksum(ChunkChecksum chunkChecksum) {
this.clientParameters.chunkChecksum(chunkChecksum);
return this;
Expand Down

0 comments on commit d568d72

Please sign in to comment.