Update keyUsage to allow ECC and RSA cipher suites #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having digitalSignature on the client and keyEncipherment on the server, we may run into this problem: https://groups.google.com/g/rabbitmq-users/c/3TQFT8jX-bk?pli=1 Some versions of OpenSSL do not seem affected, or perhaps they had a bug back in 2018. In openssl `1.0.2za-fips 24 Aug 2021`, we receive the "insufficient security" error if the client and server certificates do not have both key usages. According to this doc: https://rabbitmq.com/ssl.html#key-usage-effects-on-cipher-suites The filtering based on key usage will result in client and server not having any common cipher suites to agree on. Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
lukebakken
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having digitalSignature on the client and keyEncipherment on the
server, we may run into this problem:
https://groups.google.com/g/rabbitmq-users/c/3TQFT8jX-bk?pli=1
Some versions of OpenSSL do not seem affected, or perhaps they had a
bug back in 2018. In openssl
1.0.2za-fips 24 Aug 2021, we receive the"insufficient security" error if the client and server certificates do
not have both key usages. According to this doc:
https://rabbitmq.com/ssl.html#key-usage-effects-on-cipher-suites
The filtering based on key usage will result in client and server not
having any common cipher suites to agree on.