build(electron): Bump Electron to v2 #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSX Notarization
1. Add workflow for releases and builds 2. Temporarily remove win from testing 3. Add note about building on node 8 4. Update electron-builder 5. temporarily remove test:angular 6. Implement workflows for all OS Capture build outputs of each OS separately. There is a bug in actions/upload-artifact@v2 on macOS so use v1 for macOS.
1. User tests have been done to verify that the access your token link works, user verification works and that platform connection is successfully established. 2. Public platforms have been ordered alphabetically 3. Bump to version 1.0.3 4. Update copyright notice
This addresses the `Harfbuzz version too old (1.4.2)` error by bumping the underlying electron dependency to the next major version, v2. Fixed the underyling calls to `setZoomLevelLimits` with `setVisualZoomLevelLimits`. See https://www.electronjs.org/docs/breaking-changes#webcontents
|
Hi there, figured I'll push this PR out since I've gotten it to work on my system with this patch. I've ran the tests locally, and it seems to be working fine. |
|
fwiw, Github actions do not work for forked repos (see https://github.saobby.my.eu.orgmunity/t/github-workflow-not-running-from-pull-request-from-forked-repository/16379/47) I'm happy to help contribute to shift the testing platform to another open-source vendor such as Travis where this functionality exists. Otherwise, if I could be added to some developer group for pushing to this repo, that'll work as well. |
|
Hello @yangchoo , thank you for making this PR! I will go over it within the week. |
ghost
self-requested a review
ghost
self-assigned this
|
To build, I had to extend package.json, adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the
Harfbuzz version too old (1.4.2)error by bumpingthe underlying electron dependency to the next major version, v2.
Fixed the underyling calls to
setZoomLevelLimitswithsetVisualZoomLevelLimits.See https://www.electronjs.org/docs/breaking-changes#webcontents