Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioncore_menudb.lua:48: attempt to get length of global 'arg' (a nil value) #90

Closed
raboof opened this issue May 6, 2019 · 1 comment
Closed
Labels
LGPL Issues only present on the lgpl branch

Comments

@raboof
Copy link
Owner

raboof commented May 6, 2019

This seems like perfectly fine lua code at least on 5.2.

ldd suggests notion is loading liblua5.2.so.0 though.

@raboof raboof added the LGPL Issues only present on the lgpl branch label May 6, 2019
@raboof
Copy link
Owner Author

raboof commented May 8, 2019

fixed

@raboof raboof closed this as completed May 8, 2019
wilhelmy added a commit to wilhelmy/notion that referenced this issue Jun 22, 2019
Variadic functions were introduced in 5.0, but the method of accessing
them changed in 5.1. This makes the code incompatible with 5.0 (it is
already incompatible since at least b2b1755), which will be removed
from the build system in a subsequent commit.

Fixes raboof#124. See also raboof#90.
raboof pushed a commit that referenced this issue Jun 23, 2019
* libtu/Makefile: it's C89, not C98

* Lua 5.3 removed deprecated variadic function `arg' parameter

Variadic functions were introduced in 5.0, but the method of accessing
them changed in 5.1. This makes the code incompatible with 5.0 (it is
already incompatible since at least b2b1755), which will be removed
from the build system in a subsequent commit.

Fixes #124. See also #90.

* Remove Lua 5.0 from the build system and improve lua-detect.mk

Lua doesn't include an official pkg-config file, therefore we can't rely on
pkg-config variables like "V" or "major_version" - on my system, it detected
the 5.3 library/cflags and used the 5.1 lua/luac binaries (I have both installed
and there was a fallback to 5.1 if it couldn't query these variables from
pkg-config).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGPL Issues only present on the lgpl branch
Projects
None yet
Development

No branches or pull requests

1 participant